[platform] Add missing consistency_checker_provider fixture to test_fast_reboot_from_other_vendor#22965
Merged
rustiqly merged 1 commit intosonic-net:masterfrom Mar 25, 2026
Conversation
…ast_reboot_from_other_vendor The test passes consistency_checker_provider to get_advanced_reboot() but does not declare it as a fixture parameter, causing an AttributeError during post-reboot validation. Other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already include this fixture in their signatures. Fixes: sonic-net#22795 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
Collaborator
|
/azp run |
Contributor
Author
|
@copilot review |
github-actions
bot
requested review from
Junchao-Mellanox,
vaibhavhd and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a pytest fixture mismatch in tests/platform_tests/test_advanced_reboot.py so the “fast reboot from other vendor” advanced-reboot test can correctly use the ASIC/DB consistency checker, aligning it with the other advanced reboot tests.
Changes:
- Add the missing
consistency_checker_providerfixture parameter totest_fast_reboot_from_other_vendorso the variable passed intoget_advanced_reboot()is the actual fixture instance (not a fixture function definition).
You can also share your feedback on Copilot code review. Take the survey.
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
Collaborator
|
AI agent on behalf of Ying. Issues found:
|
Collaborator
|
Apologies for the duplicate review/comment noise earlier. We've fixed the automation to prevent repeat approvals/comments and cleaned up extras where possible. AI agent on behalf of Ying. |
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…ast_reboot_from_other_vendor (sonic-net#22965) The test passes consistency_checker_provider to get_advanced_reboot() but does not declare it as a fixture parameter, causing an AttributeError during post-reboot validation. Other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already include this fixture in their signatures. Fixes: sonic-net#22795 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Apr 1, 2026
…ast_reboot_from_other_vendor (sonic-net#22965) The test passes consistency_checker_provider to get_advanced_reboot() but does not declare it as a fixture parameter, causing an AttributeError during post-reboot validation. Other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already include this fixture in their signatures. Fixes: sonic-net#22795 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
[agent]
Add the missing
consistency_checker_providerfixture parameter totest_fast_reboot_from_other_vendor.The test body passes
consistency_checker_providertoget_advanced_reboot(), but the fixture was never declared as a test parameter, causing:All other reboot tests (
test_fast_reboot,test_warm_reboot, etc.) already include this fixture in their signatures. This was introduced in PR #16877 which added the fixture to the function body but not the parameters.Fixes: #22795
Type of change
How did you test it?